beegfs: init at 6.17 #33157
beegfs: init at 6.17 #33157
Conversation
| services.beegfs = mkOption { | ||
| default = {}; | ||
| description = '' | ||
| BeeGFS configurations. Every mount point requires a seperate configuration. |
|
|
||
| makeWrapper ${pkgs.beegfs}/bin/beegfs-check-servers \ | ||
| $out/bin/beegfs-check-servers-${name} \ | ||
| --add-flags -c --add-flags "${configClientFilename name}" \ |
There was a problem hiding this comment.
--add-flags "-c ${configClientFilename name}" is also supported.
nixos/tests/beegfs.nix
Outdated
| name = "beegfs"; | ||
|
|
||
| nodes = { | ||
| #admon = admon; |
There was a problem hiding this comment.
Why is admon commented out?
There was a problem hiding this comment.
I removed it for now. admon is not essential but only for monitoring purposes. At the moment I could only test if the service starts successfully.
nixos/tests/beegfs.nix
Outdated
| connAuthFile="beegfs/auth-def.key"; | ||
|
|
||
| client = { config, pkgs, lib, ... } : { | ||
| networking.firewall.enable = false; |
There was a problem hiding this comment.
BeeGFS module should probably configure firewall, rather than requiring users to configure or disable it. (If this is difficult to implement, it may be left for the future.)
There was a problem hiding this comment.
It is possible but I'd rather leave that for the future, since there are a least two ways to configure the ports. Either manually via extraConfig for each daemon or shifting the standard ports (connPortShift). Is there a good example module for a case like that?
There was a problem hiding this comment.
We would not extract port options from extraConfig, so we would configure firewall only based on the connPortShift (and possibly other port-specific options), but that firewall configuration may be left for the user to override in configuration. I have not found examples of this in Nixpkgs.
There was a problem hiding this comment.
This was respected with openFirewall boolean option in various services.
|
Thanks for the feedback. Here are @ck3d's comments: ck3d@db5704e |
orivej
force-pushed
the
beegfs-pr
branch
2 times, most recently
from
820ebbd
to
708e887
Compare
|
Thank you! |
package, kernel module, nixos module, and nixos test
BeeGFS 6.17 fails to build with Linux 4.14.
Motivation for this change
BeeGFS (former FhFS) is a distributed file system commonly used in high performance computing environments. This PR also integrates the package with NixOS.
Contents:
Thanks to @ck3d for comments.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)