CB-239: Reference review style guide when writing a review #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferbncode
requested changes
Dec 15, 2017
| @@ -23,8 +23,10 @@ | |||
| </div> | |||
| <div class="form-group"> | |||
| <small class="text-muted pull-left" style="font-style:italic;"> | |||
| {{ _('You can use <a href="%(url)s" target="_blank">Markdown</a> syntax to apply custom formatting.', | |||
| url='http://daringfireball.net/projects/markdown/syntax') }} | |||
| {{ _('Make sure to keep the <a href="%(style_guide_url)s" target="_blank">style guide</a> in mind when writing. | |||
There was a problem hiding this comment.
I think we can write the statement such that it doesn't seem as a strict compulsion/constraint. Something like:
"You can read the style guide for writing good CritiqueBrainz reviews!"
ferbncode
reviewed
Dec 15, 2017
| {{ _('You can use <a href="%(url)s" target="_blank">Markdown</a> syntax to apply custom formatting.', | ||
| url='http://daringfireball.net/projects/markdown/syntax') }} | ||
| {{ _('You can read the <a href="%(style_guide_url)s" target="_blank">style guide</a> for writing good CritiqueBrainz reviews! | ||
| Remember, you can use <a href="%(markdown_url)s" target="_blank">Markdown</a> syntax to apply custom formatting.', |
There was a problem hiding this comment.
Also, I suggest we change Remember to Also or Furthermore.
Also, the next sentence (about using markdown) gets little out of focus. We can make use of a <br/> bringing it to a new line.
ferbncode
approved these changes
Dec 15, 2017
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
Minor change - just added it before the "you can use markdown" message.