Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Neovim wrapper #32657

Closed
wants to merge 0 commits into from
Closed

[RFC] Neovim wrapper #32657

wants to merge 0 commits into from

Conversation

teto
Copy link
Member

@teto teto commented Dec 14, 2017

Motivation for this change

Adding a python package to the neovim environment should not trigger a recompilation. Neovim compilation time is short but between home-manager/nixops/nixos-rebuild, it can get annoying.

This creates a neovim wrapper that just setups the correct neovim configuration (python packages/ ruby etc).

Mostly I had 2 questions:
-What should be the wrapper name for the .desktop file for instance
-recent versions of neovim allows to override the clipboard via g:clipboard, maybe it would be better to use this than patch upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member Author

teto commented Dec 29, 2017

It seems to work here so setting this to RFC, hopefully others can test it too.
in neovim 0.2.2, one can set g:clipboard so the current patch
sed -i -e "s|'xsel|'${xsel}/bin/xsel|" $out/share/nvim/runtime/autoload/provider/clipboard.vim
could be replaced too.

@teto teto changed the title [WIP] Neovim wrapper [RFC] Neovim wrapper Dec 29, 2017
@teto teto closed this Jan 9, 2018
@teto teto deleted the neovim branch January 9, 2018 03:24
@teto teto mentioned this pull request Jan 9, 2018
8 tasks
@teto
Copy link
Member Author

teto commented Jan 9, 2018

I made a mistake while in detached state and removed the branch. Reopened at #33639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants