Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: set default version to 0.11 #32652

Merged
merged 1 commit into from Dec 14, 2017
Merged

terraform: set default version to 0.11 #32652

merged 1 commit into from Dec 14, 2017

Conversation

phunehehe
Copy link
Contributor

Motivation for this change

The latest minor release should be safe enough for master?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@copumpkin
Copy link
Member

Seems fine to me. @shlevy @zimbatm might have opinions, but barring any strong objection I think we should stick to latest versions

@zimbatm zimbatm merged commit d481f9a into NixOS:master Dec 14, 2017
@zimbatm
Copy link
Member

zimbatm commented Dec 14, 2017

thanks!

@phunehehe phunehehe deleted the terraform branch December 14, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@phunehehe @copumpkin @zimbatm @shlevy @GrahamcOfBorg