Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parcellite: wrap to add runtime deps #32360

Closed
wants to merge 1 commit into from
Closed

parcellite: wrap to add runtime deps #32360

wants to merge 1 commit into from
+9 −3

Conversation

gleber
Copy link
Contributor

@gleber gleber commented Dec 5, 2017

parcellite depends on ability to shell out to which and xdotool to perform
some of its functions. This ensures that these programs are present in the PATH
when program is being run.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@gleber
parcellite: wrap to add runtime deps

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9064f7e 
parcellite depends on ability to shell out to `which` and `xdotool` to perform
some of its functions. This ensures that these programs are present in the PATH
when program is being run.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 5, 2017
@rycee
Copy link
Member

rycee commented Dec 6, 2017

Just noticed this. I made #32364 at roughly the same time :-)

I somewhat prefer my PR because it also uses wrapGAppsHook to fix the icons.

@gleber
Copy link
Contributor Author

gleber commented Dec 7, 2017

#32364 is better. I'm closing this one.

@gleber gleber closed this Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gleber @rycee @GrahamcOfBorg