Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fab6c5ad8cc1
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 80b3b3dc9ed0
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 1, 2017

  1. Don't unconditionally emit debug level info from RACC

    In
    3fe1cc2,
    jruby's version of racc/parser.rb was brought in line with MRI
    racc/parser.rb. This brought along a change to the yyparse method which
    changed the last argument from false to true. This causes the java racc
    parser implementation to unconditionally emit very noisy debug output
    whenever yyparse is called, where previously it would not emit such
    output. Passing true is safe for the pure ruby parser, as it ignores the
    argument entirely and does nothing with it. It is also safe for the
    native c parser, as that parser only emits debug info if it is compiled
    with DEBUG set. Tenderlove's version of racc disabled debug by default
    in
    ruby/racc@c5359ab,
    but it looks like MRI never picked up that change.
    For a time, true was passed and debugging info was not emitted (between
    9.1.9.0 and 9.1.12.0). This was because in the merge to bring
    racc/parser.rb in line with MRI, the loading of the java cparse library
    no longer happened, so the pure ruby version of the library was used
    which ignores the debug parameter entirely. This changed in
    baeaad1
    when the cparse-java.jar was being loaded again for jruby.
    haus committed Dec 1, 2017
    Copy the full SHA
    de12ad3 View commit details

Commits on Dec 5, 2017

  1. Merge pull request #4881 from haus/jruby-9.1-dont-emit-debug-in-racc

    Don't unconditionally emit debug level info from RACC
    headius authored Dec 5, 2017
    Copy the full SHA
    80b3b3d View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/ruby/stdlib/racc/parser.rb
2 changes: 1 addition & 1 deletion lib/ruby/stdlib/racc/parser.rb
Original file line number Diff line number Diff line change
@@ -322,7 +322,7 @@ def _racc_do_parse_rb(arg, in_debug)
# RECEIVER#METHOD_ID is a method to get next token.
# It must 'yield' the token, which format is [TOKEN-SYMBOL, VALUE].
def yyparse(recv, mid)
__send__(Racc_YY_Parse_Method, recv, mid, _racc_setup(), true)
__send__(Racc_YY_Parse_Method, recv, mid, _racc_setup(), false)
end

def _racc_yyparse_rb(recv, mid, arg, c_debug)