Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5899fa124b5e
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 78146d5a95f5
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 2, 2017

  1. Re-add excludes for tests failing on Travis.

    @headius
    headius committed Dec 2, 2017
    Copy the full SHA
    0faf6a3 View commit details

Commits on Dec 5, 2017

  1. Remove passing defined? tag.

    @headius
    headius committed Dec 5, 2017
    Copy the full SHA
    78146d5 View commit details
Showing with 2 additions and 1 deletion.
  1. +0 −1 spec/tags/ruby/language/defined_tags.txt
  2. +2 −0 test/mri/excludes/TestProcess.rb
1 change: 0 additions & 1 deletion spec/tags/ruby/language/defined_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
fails(jruby/jruby#3903):The defined? keyword for a scoped constant returns nil when a constant is scoped to an undefined constant
fails:The defined? keyword for an expression with logical connectives returns nil for an expression with '!' and an unset class variable
fails:The defined? keyword for an expression with logical connectives returns nil for an expression with 'not' and an unset class variable
fails:The defined? keyword for a variable scoped constant returns nil if the scoped constant is not defined
2 changes: 2 additions & 0 deletions test/mri/excludes/TestProcess.rb
View file
Original file line number Diff line number Diff line change
@@ -46,6 +46,7 @@
exclude :test_gid_sid_available?, "unimplemented"
exclude :test_kill_at_spawn_failure, "thread lifecycle at process boundaries?"
exclude :test_no_curdir, "won't work due changed wd detection (since 1e30600bdbbf483a)"
exclude :test_popen_noshell, "Fails on Travis"
exclude :test_popen_wordsplit, "needs investigation"
exclude :test_popen_wordsplit_beginning_and_trailing_spaces, "needs investigation"
exclude :test_process_detach, "uses fork"
@@ -56,6 +57,7 @@
exclude :test_spawn_wordsplit, "needs investigation"
exclude :test_status_kill, "needs investigation"
exclude :test_status_quit, "needs investigation"
exclude :test_system_wordsplit, "Fails on Travis"
exclude :test_threading_works_after_exec_fail, "requires fork"
exclude :test_uid_re_exchangeable_p, "unimplemented"
exclude :test_uid_sid_available?, "unimplemented"