Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcscd: add plugin for ACS ACR38U smartcard reader #32355

Closed
wants to merge 1 commit into from
Closed

pcscd: add plugin for ACS ACR38U smartcard reader #32355

wants to merge 1 commit into from

Conversation

berce
Copy link
Contributor

@berce berce commented Dec 5, 2017

Motivation for this change

Add hardware support for specific smartcard reader hardware.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor bjornfor self-assigned this Dec 5, 2017
@berce
Copy link
Contributor Author

berce commented Dec 5, 2017

Like other 'plugins' for pcscd

  • this plugin is added to top-level/all-packages.nix. Wouldn't it be better to list the plugins in pcscd.nix instead?
  • it is located in pkgs/tools/security. Wouldn't nixos/services/hardware/ be a better place? That's where pcscd is.

Currently it's hard to find what plugins are available for pcscd.

@bjornfor
Copy link
Contributor

bjornfor commented Dec 5, 2017

Applied to master (b8b7428). Thanks!

@bjornfor bjornfor closed this Dec 5, 2017
@bjornfor
Copy link
Contributor

bjornfor commented Dec 5, 2017

No strong opinion on location of packages. Submit a PR :-)

@berce berce deleted the libacr38u branch December 5, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjornfor bjornfor

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@berce @bjornfor @GrahamcOfBorg