Properly test this and make it asserts since it should never fail.

headius · headius · commit fab6c5ad8cc1 · 2017-12-05T11:29:05.000-06:00
Fixes #4880.
diff --git a/core/src/main/java/org/jruby/java/codegen/RealClassGenerator.java b/core/src/main/java/org/jruby/java/codegen/RealClassGenerator.java
@@ -136,9 +136,12 @@ public static Class createRealImplClass(Class superClass, Class[] interfaces, Ru
         Map<String, List<Method>> simpleToAll = buildSimpleToAllMap(interfaces, superTypeNames, rubyClass);
 
         Class newClass = defineRealImplClass(ruby, name, superClass, superTypeNames, simpleToAll);
-        if (!newClass.isAssignableFrom(interfaces[0])) {
-            new RuntimeException(newClass.getInterfaces()[0].getClassLoader() + " " + interfaces[0].getClassLoader());
+
+        // Confirm all interfaces got implemented
+        for (Class ifc : interfaces) {
+            assert ifc.isAssignableFrom(newClass);
         }
+
         return newClass;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -136,9 +136,12 @@ public static Class createRealImplClass(Class superClass, Class[] interfaces, Ru`
`136`	`136`	`Map<String, List<Method>> simpleToAll = buildSimpleToAllMap(interfaces, superTypeNames, rubyClass);`
`137`	`137`
`138`	`138`	`Class newClass = defineRealImplClass(ruby, name, superClass, superTypeNames, simpleToAll);`
`139`		`- if (!newClass.isAssignableFrom(interfaces[0])) {`
`140`		`- new RuntimeException(newClass.getInterfaces()[0].getClassLoader() + " " + interfaces[0].getClassLoader());`
	`139`	`+`
	`140`	`+ // Confirm all interfaces got implemented`
	`141`	`+ for (Class ifc : interfaces) {`
	`142`	`+ assert ifc.isAssignableFrom(newClass);`
`141`	`143`	`}`
	`144`	`+`
`142`	`145`	`return newClass;`
`143`	`146`	`}`
`144`	`147`