Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.gnome_online_accounts: enable more backends #32358

Merged
merged 3 commits into from Dec 5, 2017
Merged

gnome3.gnome_online_accounts: enable more backends #32358

merged 3 commits into from Dec 5, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Dec 5, 2017 •
edited

Motivation for this change

In particular, last.fm.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added 0.kind: enhancement 6.topic: GNOME GNOME desktop environment and its underlying platform labels Dec 5, 2017
@jtojnar jtojnar merged commit 3f45966 into NixOS:master Dec 5, 2017
@jtojnar jtojnar deleted the goa-last.fm branch December 5, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg