Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcomps: init at 0.1.8 #32348

Closed
wants to merge 1 commit into from
Closed

libcomps: init at 0.1.8 #32348

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 5, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member Author

FRidh commented Dec 5, 2017

  • I will open a PR upstream for the patch
  • Currently I have the following issue:
$ nix-shell -p 'python3.withPackages(ps: with ps; [ libcomps ])' -I nixpkgs=. --run "python -c 'import libcomps'"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/nix/store/j5dgh01vxx4jq4in1i7fc2c30hirbjml-python3-3.6.3-env/lib/python3.6/site-packages/libcomps/__init__.py", line 1, in <module>
    from ._libpycomps import *
ImportError: libz.so.1: cannot open shared object file: No such file or directory

@FRidh
Copy link
Member Author

FRidh commented Dec 7, 2017

Why can't upstream accept your patch?

I did not mention they could/would not accept the patch.

@FRidh
Copy link
Member Author

FRidh commented Dec 31, 2017

Don't need this anymore so closing.

@FRidh FRidh closed this Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @GrahamcOfBorg