Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "qt5: 5.9.1 -> 5.9.3" #32259

Merged
merged 1 commit into from Dec 2, 2017
Merged

Revert "qt5: 5.9.1 -> 5.9.3" #32259

merged 1 commit into from Dec 2, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Dec 2, 2017 •
edited

Motivation for this change

KDE frameworks 5.40 are not compatible with Qt 5.9.3: #32253. We should wait for a version that does not require cherry picking upstream patches because we may miss some, and updating Qt is not urgent.

This reverts commit bd71d3a (#32100).

Things done

Tested switching to the resulting configuration with the KDE desktop.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Revert "qt5: 5.9.1 -> 5.9.3"
a1b77bf 
KDE frameworks 5.40 are not compatible with Qt 5.9.3: NixOS#32253

This reverts commit bd71d3a (NixOS#32100).
@orivej orivej requested review from ttuegel and LnL7 December 2, 2017 18:43
@orivej orivej merged commit e29b1f4 into NixOS:master Dec 2, 2017
This was referenced Dec 2, 2017
Closed
Merged
@orivej orivej deleted the qt branch December 5, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @LnL7 @GrahamcOfBorg