Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed administrator to moderator for consistency #161

Closed
wants to merge 2 commits into from
Closed

changed administrator to moderator for consistency #161

wants to merge 2 commits into from

Conversation

lilbool
Copy link

@lilbool lilbool commented Dec 3, 2017

GCI task

@brainzbot
Copy link
Member

Can one of the admins verify this patch?

1 similar comment
@brainzbot
Copy link
Member

Can one of the admins verify this patch?

@anshuman73
Copy link
Contributor

@brainzbot whitelist

Copy link
Member

@ferbncode ferbncode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required. There is no need to modify the .po and the .pot files manually. Make sure you generate them (see comments) and add those changes in a separate commit.

@@ -211,7 +211,7 @@ msgid "Please sign in to access this page."
msgstr ""

#: critiquebrainz/frontend/login/__init__.py:46
msgid "You must be an administrator to view this page."
msgid "You must be a moderator to view this page."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to change the .pot file. See http://babel.pocoo.org/en/latest/cmdline.html. CB uses pybabel for compiling translations. Make the changes just in the python/html code.

@@ -1848,7 +1848,7 @@ msgid "Can't find a review with the specified ID."
msgstr ""

#: critiquebrainz/frontend/views/review.py:75
msgid "Review has been hidden. You need to be an administrator to view it."
msgid "Review has been hidden. You need to be a moderator to view it."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .mo files are generated via the pybabel compile command. You may wanna just edit the code in a separate commit (the .py and the jinja files (if any)) and then use pybabel commands to generate the messages.pot(using pybabel extract command) and the messages.po (using pybabel compile command) files. Then add the changed files in a separate commit.

@ferbncode
Copy link
Member

I think that the project maintainer can only build all translations. So, it's okay if you don't modify the .pot and .po files. Also, please push the changes to this pull request rather than opening a new one. Read more about updating pull requests here: https://stackoverflow.com/questions/9790448/how-to-update-a-pull-request-from-forked-repo. Also, please follow guidelines here while creating a pull request: https://github.com/metabrainz/guidelines/blob/master/GitHub.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants