New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed administrator to moderator for consistency #161
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
@brainzbot whitelist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are required. There is no need to modify the .po
and the .pot
files manually. Make sure you generate them (see comments) and add those changes in a separate commit.
@@ -211,7 +211,7 @@ msgid "Please sign in to access this page." | |||
msgstr "" | |||
|
|||
#: critiquebrainz/frontend/login/__init__.py:46 | |||
msgid "You must be an administrator to view this page." | |||
msgid "You must be a moderator to view this page." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to change the .pot
file. See http://babel.pocoo.org/en/latest/cmdline.html. CB uses pybabel
for compiling translations. Make the changes just in the python/html code.
@@ -1848,7 +1848,7 @@ msgid "Can't find a review with the specified ID." | |||
msgstr "" | |||
|
|||
#: critiquebrainz/frontend/views/review.py:75 | |||
msgid "Review has been hidden. You need to be an administrator to view it." | |||
msgid "Review has been hidden. You need to be a moderator to view it." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .mo
files are generated via the pybabel compile
command. You may wanna just edit the code in a separate commit (the .py and the jinja files (if any)) and then use pybabel
commands to generate the messages.pot
(using pybabel extract
command) and the messages.po
(using pybabel compile
command) files. Then add the changed files in a separate commit.
I think that the project maintainer can only build all |
GCI task