Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backblaze-b2: 0.6.2 -> 1.1.0 #32251

Merged
merged 1 commit into from Dec 17, 2017
Merged

Conversation

dtulig
Copy link
Contributor

@dtulig dtulig commented Dec 2, 2017

Motivation for this change

Introduces a number of bug fixes and a few new features. There is a noted breaking change: "Require --allowEmptySource to sync from empty directory, to help avoid accidental deletion of all files."

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@kevincox kevincox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@@ -1,17 +1,18 @@
{ fetchFromGitHub, makeWrapper, pythonPackages, stdenv }:

pythonPackages.buildPythonApplication rec {
name = "backblaze-b2-${version}";
version = "0.6.2";
pname = "b2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the value of separating this out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, this came from following templates within python-modules.nix before I found backblaze-b2 as it's own package definition in tools. I'll remove the unnecessary breakout.

@orivej orivej merged commit 8bcd948 into NixOS:master Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants