Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kio: patch for Qt 5.9.3 #32253

Closed
wants to merge 1 commit into from
Closed

kio: patch for Qt 5.9.3 #32253

wants to merge 1 commit into from

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Dec 2, 2017

kio cannot create folders under Qt 5.9.3 unless we apply these upstream
patches.

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel
kio: patch for Qt 5.9.3
4de891c 
kio cannot create folders under Qt 5.9.3 unless we apply these upstream
patches.
@ttuegel ttuegel self-assigned this Dec 2, 2017
@orivej
Copy link
Contributor

orivej commented Dec 2, 2017

Do you think we should revert to Qt 5.9.1 until 5.9.3 is actually usable (due to PRs like this, or the next KDE versions)?

@orivej orivej mentioned this pull request Dec 2, 2017
Merged
8 tasks
orivej added a commit to orivej/nixpkgs that referenced this pull request Dec 2, 2017
@orivej
Revert "qt5: 5.9.1 -> 5.9.3"
a1b77bf 
KDE frameworks 5.40 are not compatible with Qt 5.9.3: NixOS#32253

This reverts commit bd71d3a (NixOS#32100).
@orivej orivej mentioned this pull request Dec 2, 2017
Merged
8 tasks
@orivej
Copy link
Contributor

orivej commented Dec 2, 2017 •
edited

Reverted to Qt 5.9.1 in #32259. I think we should just wait for the next release of KDE frameworks rather than backport fixes for Qt 5.9.3 into the current release.

@ttuegel
Copy link
Member Author

ttuegel commented Dec 2, 2017

Why? These patches were specifically recommended by KDE upstream, and now we are two bugfix releases behind on Qt.

@orivej
Copy link
Contributor

orivej commented Dec 2, 2017

These patches were specifically recommended by KDE upstream

What do you mean? Where are they recommended?

now we are two bugfix releases behind on Qt.

Looking at the list of bugs fixed in Qt 5.9.3, a lot of them were introduced in Qt 5.9.2, so we are more like one bugmake and one bugfix release behind :) But if you think that we should upgrade before KDE prepares a release that supports the new Qt, we can begin by merging this PR.

@ttuegel
Copy link
Member Author

ttuegel commented Dec 2, 2017

What do you mean? Where are they recommended?

On the kde-distro-packagers mailing list, the canonical source for such information:

https://mail.kde.org/pipermail/kde-distro-packagers/2017-November/000297.html

But if you think that we should upgrade before KDE prepares a release that supports the new Qt, we can begin by merging this PR.

No, the amount of my time consumed by this PR already exceeds its value.

@ttuegel ttuegel closed this Dec 2, 2017
@ttuegel ttuegel deleted the kio/qt-5.9.3 branch December 2, 2017 19:39
@orivej
Copy link
Contributor

orivej commented Dec 2, 2017

Thank you, if I were subscribed to that mailing list I would have known that Qt 5.9.3 should not have been merged just yet, so I have subscribed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ttuegel ttuegel

Labels
0.kind: bug 6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @orivej @GrahamcOfBorg