Consistently use executors to schedule work #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- customization points for thread-executors now don't rely on async/apply anymore - async(exec, ...)/apply(exec, ...) now always dispatch to executor customization points - future::then(thread_exec, ...) now dispatches to executor customization points - flyby: more proper forwarding for predecessor in executor API # Conflicts: # hpx/parallel/executors/execution.hpp # hpx/parallel/executors/thread_execution.hpp
- generalizing parallel_executor to be statically parameterized by a launch policy (introducing parallel_policy_executor<Policy>, parallel_executor is now just a alias for parallel_policy_executor<hpx::launch>) - adding test for parallel_policy_executor - parallel_policy_executor and sequenced_executor now don't use async/apply anymore # Conflicts: # hpx/parallel/executors/execution_fwd.hpp
Cleanup of #includes to avoid cyclic include dependencies - created forwarding header for types related to performance counters - refactored some code that does not have to be exposed in header files - changed executor_traits (V1) to not use apply/async anymore Also: - dataflow now schedules all work through the executor customization points
sithhell
reviewed
Dec 8, 2017
There was a problem hiding this comment.
Overall, the PR looks good to go. Please fix the one comment.
There are lots of necessary, but unrelated fixes in this changeset, would it make sense to put those in a seperate PR with meaningful commit messages? Especially regarding the parcel handling, big boot barrier and performance counter changes.
| return detail::then_execute_helper(exec, std::forward<F>(f), | ||
| std::move(fut)); | ||
| return detail::then_execute_helper(std::forward<Executor_>(exec), | ||
| std::forward<F>(f), std::move(fut)); |
There was a problem hiding this comment.
fut should be forwarded here instead of unconditionally moved.
There was a problem hiding this comment.
I don't think so. Future && fut is an rvalue reference.
sithhell
approved these changes
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3027