Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcal: init at 4.1 #32255

Closed
wants to merge 1 commit into from
Closed

gcal: init at 4.1 #32255

wants to merge 1 commit into from

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Dec 2, 2017

Motivation for this change

Add GCal package.

Gcal is a program for calculating and printing calendars. Gcal displays hybrid and proleptic Julian and Gregorian calendar sheets, respectively for one month, three months, or a whole year. It also displays eternal holiday lists for many countries around the globe, and features a very powerful creation of fixed date liststhat can be used for reminding purposes. Gcal can calculate various astronomical data and times of the Sun and the Moon for pleasure at any location, precisely enough for most civil purposes. Gcal supports some other calendar systems, for example, the Chinese and Japanese calendars, the Hebrew calendar, and the civil Islamic calendar, too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

orivej
orivej reviewed Dec 2, 2017
View reviewed changes
pkgs/applications/misc/gcal/default.nix Outdated
version = "4.1";

src = fetchurl {
url = "https://ftp.gnu.org/gnu/gcal/${name}.tar.xz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use mirror://gnu.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

pkgs/applications/misc/gcal/default.nix Outdated

enableParallelBuilding = true;

buildInputs = [ ncurses perl less ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the build need perl and less?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the build need perl and less?

Not necessarily. It works without them.

I do not know exactly why perl is checked at configuration time.

less is used as a default pager. But there are other ways of using a pager, described in the manual. Just look at the --pager option. For instance setting the environment variable PAGER.

@rycee
Copy link
Member

rycee commented Dec 6, 2017

Rebased to master in 0226077. Thanks!

@rycee rycee closed this Dec 6, 2017
@romildo romildo deleted the new.gcal branch December 6, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @rycee @orivej @GrahamcOfBorg