Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_compose: 1.15.0 -> 1.18.0 #32843

Closed
wants to merge 1 commit into from
Closed

docker_compose: 1.15.0 -> 1.18.0 #32843

wants to merge 1 commit into from

Conversation

mbode
Copy link
Contributor

@mbode mbode commented Dec 19, 2017 •
edited

Needed to upgrade python dependencies:
docker: 2.5.1 -> 2.6.1
texttable: 0.8.4 -> 0.9.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mbode mbode requested a review from FRidh as a code owner December 19, 2017 12:52
FRidh
FRidh reviewed Dec 19, 2017
View reviewed changes
pkgs/top-level/python-packages.nix Outdated
@@ -18377,11 +18377,11 @@ in {
};

texttable = self.buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.

Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mbode
docker_compose: 1.15.0 -> 1.18.0
b34c635 
upgrade python dependencies:
docker: 2.5.1 -> 2.6.1
texttable: 0.8.4 -> 0.9.0
@FRidh
Copy link
Member

FRidh commented Dec 22, 2017

cc maintainer @jgeerds

@FRidh FRidh self-assigned this Dec 30, 2017
@FRidh
Copy link
Member

FRidh commented Dec 31, 2017

These changes are now in #33204.

@FRidh FRidh closed this Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbode @FRidh @GrahamcOfBorg