Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize and add error messages for unterminated literals #5409

Merged

Conversation

straight-shoota
Copy link
Member

This PR normalizes error messages for unterminated literals to start with an uppercase letter and use a lower case letter for the literal type. It also fixes reported literal type which was previously string for any percent literal. It adds some specs for several literals.

@RX14 RX14 added this to the Next milestone Dec 19, 2017
@RX14 RX14 merged commit 993916a into crystal-lang:master Dec 19, 2017
@straight-shoota straight-shoota deleted the jm-fix-unterminated-literals branch December 19, 2017 14:34
@RX14
Copy link
Contributor

RX14 commented Dec 19, 2017

Look at circleCI: this actually broke the build but broke it in a way where it exited 0. Please fix the compiler specs!

@straight-shoota
Copy link
Member Author

I'll fix the missing specs. But how is it possible that it exits with 0?

@RX14
Copy link
Contributor

RX14 commented Dec 19, 2017

@straight-shoota we should probably exit with an error code if any at_exit handlers fail to run.

@straight-shoota
Copy link
Member Author

Also, I can't reproduce the Index out of bounds with crystal 0.23.0+313 (0.24.0) on WSL Ubuntu 14.04

straight-shoota added a commit to straight-shoota/crystal that referenced this pull request Dec 19, 2017
straight-shoota added a commit to straight-shoota/crystal that referenced this pull request Dec 19, 2017
jhass pushed a commit that referenced this pull request Dec 19, 2017
@RX14 RX14 modified the milestones: 0.24.1, Next Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants