Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] qsynth: 0.4.4 -> 0.5.0 #32836

Closed
wants to merge 1 commit into from
Closed

[WIP] qsynth: 0.4.4 -> 0.5.0 #32836

wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Dec 19, 2017 •
edited

Motivation for this change

When I do nix-env -f $NIXPKGS -iA qsynth I get:
CMake Error: File /tmp/nix-build-qsynth-0.5.0.drv-0/qsynth-0.5.0/src/qsynth.desktop.in does not exist..

When I run:

unpackPhase
cd $dir
configurePhase

it runs OK

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 19, 2017

@GrahamcOfBorg eval

@globin
Copy link
Member

globin commented Dec 19, 2017

@GrahamcOfBorg build qsynth

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 19, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

  Debugger stack-trace (gdb) . . . . . . . . . . . .: no

  Install prefix . . . . . . . . . . . . . . . . . .: /nix/store/j9gifpf86bdyisjch3p2x9nyh1chv0dd-qsynth-0.5.0

Now type 'make', followed by 'make install' as root.

-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-qsynth-0.5.0.drv-0/qsynth-0.5.0/build/CMakeFiles/CMakeOutput.log".
builder for ‘/nix/store/66x6i991h6705qlrsxqivhrylccigxdb-qsynth-0.5.0.drv’ failed with exit code 1
error: build of ‘/nix/store/66x6i991h6705qlrsxqivhrylccigxdb-qsynth-0.5.0.drv’ failed

GrahamcOfBorg
GrahamcOfBorg reviewed Dec 19, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

  Debugger stack-trace (gdb) . . . . . . . . . . . .: no

  Install prefix . . . . . . . . . . . . . . . . . .: /nix/store/4x7d9jdlzldxsmrhka4hs3841xbij61h-qsynth-0.5.0

Now type 'make', followed by 'make install' as root.

-- Configuring incomplete, errors occurred!
See also "/build/qsynth-0.5.0/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/mfhc1xsviiwzjj81fzcx3bg571hfkh3p-qsynth-0.5.0.drv' failed with exit code 1
error: build of '/nix/store/mfhc1xsviiwzjj81fzcx3bg571hfkh3p-qsynth-0.5.0.drv' failed

@orivej
Copy link
Contributor

orivej commented Jan 6, 2018

The default phases are like eval "${configurePhase:-configurePhase}", in this case $configurePhase is cmakeConfigurePhase. You can build without cmake, or find the source that contains src/qsynth.desktop.in.

@orivej orivej changed the title qsynth: 0.4.4 -> 0.5.0 [WIP] qsynth: 0.4.4 -> 0.5.0 Jan 6, 2018
@magnetophon
Copy link
Member Author

fixed by cf52f8e

@magnetophon magnetophon closed this Jan 6, 2018
@magnetophon magnetophon reopened this Jan 6, 2018
@magnetophon magnetophon closed this Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@magnetophon @grahamc @globin @orivej @GrahamcOfBorg