Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 5b6c5964b088
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 69345ec37b8d
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Dec 19, 2017

  1. makeSetupHook: make the default name "hook" overridable 

    for occasional convenience while looking at drv paths,
such as in the output of nix-build and nix-diff.
    @orivej
    orivej committed Dec 19, 2017
    Copy the full SHA
    170a964 View commit details
    Browse the repository at this point in the history

  2. ld-is-cc-hook: init 

    This hook sets LD to CC, for use with software that works as if LD=$CC when LD
is unset, and does not work when LD=ld.
    @orivej
    orivej committed Dec 19, 2017
    Copy the full SHA
    e2c8655 View commit details
    Browse the repository at this point in the history

  3. perlPackages: use ld-is-cc-hook to fix build 

    after #29396 removed `-L path/to/dir/of/libstdc++.so` from ld flags

See #29396 (comment)

Module::Build build helper works correctly when LD is unset (taking LD from Perl
config to be `cc`).  However, we can not unset LD because this goes contrary to
the cross compilation effort, and we can not make it propagate ld-is-cc-hook
because it breaks e.g. the build of `libguestfs`. However, #29396 makes LD=ld
incompatible with just 3 perl packages; they are individually fixed by this
commit.
    @orivej
    orivej committed Dec 19, 2017
    Copy the full SHA
    69345ec View commit details
    Browse the repository at this point in the history