Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django: add 2.0 release #32852

Merged
merged 1 commit into from Dec 30, 2017
Merged

django: add 2.0 release #32852

merged 1 commit into from Dec 30, 2017

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

django 2.0 release not in nixpkgs.

I think we should eventually change django attribute to point to 2.0 branch- I didn't put that in this commit since only py3k is supported.

also not sure if we need to keep old versions hanging around in nixpkgs- i think most people manage project dependencies with pypi2nix, so all out-of-tree anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.


disabled = !isPy3k;

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi?


meta = {
description = "A high-level Python Web framework";
homepage = https://www.djangoproject.com/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license? Maintainer?

@lsix
Copy link
Member

lsix commented Dec 22, 2017

Hi,

Thanks for this PR. I think django-1.11 should still be supported since:

  • django-2 drops python2 support as you mentioned (which is still the default python interpreter in nixpkgs)
  • django-1.11 is a LTS release that will maintained longer than django-2.0

We could be just fine maintaining only 2 versions of django: latest and LTS.

If the django attribute points to the 2.0 branch, I’d like to have a django_lts that could be used like

pkgs.python3.override {
      packageOverrides = self: super: {
          django = self.django_lts;
      };
}

The other approach would be to have the django attrubute point to 1.11 branch and a new django_latest attribute.

I am fine with both approaches.

@FRidh
Copy link
Member

FRidh commented Dec 27, 2017

@lsix can there not be more than one lts at any time?

@lsix
Copy link
Member

lsix commented Dec 27, 2017

Yes, there can be multiplu LTS at any time (to give time to migrate from one LTS to the other):

django schedule

however, I am not sure we want to support multiple LTS release at once in nixpkgs. Only one that will be maintained for the lifetime of a nixos release, and if many are available I would say only the most recent.

Anyway, both releases will have an attribute named after its version (django_1_11 and django_2_0), having a django_lts attribute is mainly used as an alias and to clearly state that a version is not an outdated one that should be dropped but a legitimate maintained release in nixpkgs.

@FRidh FRidh merged commit 9d4de1e into NixOS:master Dec 30, 2017
@georgewhewell georgewhewell deleted the django-2_0 branch December 30, 2017 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants