New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django: add 2.0 release #32852
django: add 2.0 release #32852
Conversation
|
||
disabled = !isPy3k; | ||
|
||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchPypi?
|
||
meta = { | ||
description = "A high-level Python Web framework"; | ||
homepage = https://www.djangoproject.com/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license? Maintainer?
Hi, Thanks for this PR. I think
We could be just fine maintaining only 2 versions of django: latest and LTS. If the pkgs.python3.override {
packageOverrides = self: super: {
django = self.django_lts;
};
} The other approach would be to have the I am fine with both approaches. |
2887ad8
to
f85da5a
Compare
@lsix can there not be more than one |
Yes, there can be multiplu LTS at any time (to give time to migrate from one LTS to the other): however, I am not sure we want to support multiple LTS release at once in nixpkgs. Only one that will be maintained for the lifetime of a nixos release, and if many are available I would say only the most recent. Anyway, both releases will have an attribute named after its version ( |
Motivation for this change
django 2.0 release not in nixpkgs.
I think we should eventually change
django
attribute to point to 2.0 branch- I didn't put that in this commit since only py3k is supported.also not sure if we need to keep old versions hanging around in nixpkgs- i think most people manage project dependencies with pypi2nix, so all out-of-tree anyway.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)