docker_compose: add darwin to platforms #32842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Dec 19, 2017
| @@ -41,7 +41,7 @@ buildPythonApplication rec { | |||
| homepage = https://docs.docker.com/compose/; | |||
| description = "Multi-container orchestration for Docker"; | |||
| license = licenses.asl20; | |||
| platforms = platforms.linux; | |||
| platforms = platforms.linux ++ platforms.darwin; | |||
There was a problem hiding this comment.
the whole line should be removed instead as it is already set to this value by buildPythonPackage
mbode
force-pushed
the
docker_compose_darwin
branch
from
7704fe3
to
2bb2428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
docker_compose should be available on darwin
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)