Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chefdk: 2.3.4 -> 2.4.17 #32412

Merged
merged 2 commits into from Dec 7, 2017
Merged

chefdk: 2.3.4 -> 2.4.17 #32412

merged 2 commits into from Dec 7, 2017

Conversation

tomster
Copy link
Contributor

@tomster tomster commented Dec 7, 2017

Motivation for this change

need newer version of inspec that is bundled with chef-dk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [?] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tomster
Copy link
Contributor Author

tomster commented Dec 7, 2017

i built this using the instructions in default.nix (nix-shell -p bundix -p gcc -p libxml2 -p zlib --run "bundix -mdl") and then activated a nix-shell using my local nixpkgs clone and successfully ran a kitchen test suite that relies on this newer version. that was basically my testing....

@Mic92 Mic92 merged commit a02691a into NixOS:master Dec 7, 2017
@Mic92
Copy link
Member

Mic92 commented Dec 7, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomster @Mic92 @globin @GrahamcOfBorg @Janik-Haag