Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: checkMeta fixes for x86_64-linux #32410

Merged
merged 1 commit into from Dec 7, 2017
Merged

treewide: checkMeta fixes for x86_64-linux #32410

merged 1 commit into from Dec 7, 2017

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Dec 7, 2017

Motivation for this change

Extracted from #32365

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc grahamc added 0.kind: enhancement 8.has: clean-up 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 7, 2017
@grahamc grahamc requested a review from FRidh as a code owner December 7, 2017 12:52
@grahamc grahamc merged commit 5b9e29c into NixOS:master Dec 7, 2017
@grahamc grahamc deleted the check-meta branch December 7, 2017 13:08
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
0.kind: enhancement 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@grahamc @samueldr @GrahamcOfBorg @vcunat