Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arp-scan: 1.9 -> 1.9.5 #32408

Merged
merged 2 commits into from Jul 5, 2018
Merged

arp-scan: 1.9 -> 1.9.5 #32408

merged 2 commits into from Jul 5, 2018

Conversation

mikoim
Copy link
Contributor

@mikoim mikoim commented Dec 7, 2017

Motivation for this change
  • Change upstream to GitHub
    There is no release in recent years but development is undergoing on GitHub by the original author.
  • Add missing dependency
    get-oui and get-iab need some Perl modules, but they are lacked.

cc @bjornfor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

bjornfor commented Dec 7, 2017

Please ask upstream to make a new release.

If packaging unreleased software we invert QA responsibility between upstream/downstream.

@mikoim
Copy link
Contributor Author

mikoim commented Dec 7, 2017

That was my lack of understanding. This commit includes a point of minor release update. Do you think that it's unsatisfactory for QA yet? If not, I'll change rev to royhills/arp-scan@5d2d1f7.

@bjornfor
Copy link
Contributor

bjornfor commented Dec 8, 2017

Please see royhills/arp-scan#28.

matthewbauer
matthewbauer requested changes Apr 21, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tagged release

@7c6f434c
Copy link
Member

Should we just recognise bfee8899993fbcca74de44c594903e0827da10b5 as the 1.9.5 release? Looks like negotiations with upstream about a git tag are not succeeding…

@bjornfor
Copy link
Contributor

IMHO we should not. But if you (community) feel otherwise, I won't object.

@orivej
Copy link
Contributor

orivej commented Jun 11, 2018

Since the project is abandoned, if the update is needed I'd set rev = "96d195093de46e67ea2bda0f00700e37dd11df3f" (the last commit on master) and merge this.

@bjornfor
Copy link
Contributor

bjornfor commented Jul 4, 2018

@mikoim: Upstream finally tagged 1.9.5! Would you mind refreshing the PR? Also, if the missing dependencies exist in the current version, please put that commit first. (Fix bugs first, then add features.)

@orivej
Copy link
Contributor

orivej commented Jul 4, 2018

@bjornfor, 1.9.5 is an ancient tag.

@7c6f434c
Copy link
Member

7c6f434c commented Jul 4, 2018

@orivej it is the latest version that got a version bump in README, and it is much newer than 1.9

@orivej
Copy link
Contributor

orivej commented Jul 4, 2018

OK, but it was made before this PR, and @mikoim initially wrote "There is no release in recent years but development is undergoing on GitHub by the original author", so they were aware of 1.9.5.

@bjornfor
Copy link
Contributor

bjornfor commented Jul 4, 2018

Right, it's an old tag, but it is the latest release. I think we should stick with releases and let upstream decide when the code is ready for downstream.

@7c6f434c
Copy link
Member

7c6f434c commented Jul 4, 2018

It is an old revision, but it is newly tagged.

@mikoim mikoim changed the title arp-scan: 1.9 -> 2017-07-17 arp-scan: 1.9 -> 1.9.5 Jul 4, 2018
@mikoim
Copy link
Contributor Author

mikoim commented Jul 4, 2018 •
edited

Say hello from 6 months ago! Finally, the author tagged his repo. It took a long long time.

@matthewbauer now using tagged release

@matthewbauer matthewbauer merged commit 3026a77 into NixOS:master Jul 5, 2018
@XVilka XVilka mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikoim @bjornfor @7c6f434c @orivej @matthewbauer @GrahamcOfBorg