Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CircularFingerprinter.rubricTetrahedralsCdk() #395

Merged
merged 1 commit into from Dec 7, 2017
Merged

Fix CircularFingerprinter.rubricTetrahedralsCdk() #395

merged 1 commit into from Dec 7, 2017

Conversation

k-ujihara
Copy link
Contributor

Use getConfigOrder instead of getConfig. Test case is not created yet, but BayesianTest.testFolding will pass with this fix.

@k-ujihara
Fix CircularFingerprinter.rubricTetrahedralsCdk()
f473c70 
Use getConfigOrder instead of getConfig. This fix is to pass
BayesianTest.testFolding test.
@johnmay johnmay merged commit 56388e4 into cdk:master Dec 7, 2017
@johnmay
Copy link
Member

johnmay commented Dec 7, 2017 •
edited

Doh was correct when i made the patch in #379 but changed the API #387 (and 379 was applied after 387).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k-ujihara @johnmay