Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "firefox-esr: 52.5.0esr -> 52.5.1esr" #32418

Closed
wants to merge 1 commit into from

Conversation

oxij
Copy link
Member

@oxij oxij commented Dec 7, 2017

Motivation for this change

This reverts commit 282bd5c.

I have no idea why, but Mozilla reverted their distribution too. The source file
is no longer available on any mirrors, binary they distribute is
reverted too.

This is a version of vanilla firefox that supports old plugins, so it
shouldn't be broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • It works.
  • Fits CONTRIBUTING.md.

This reverts commit 282bd5c.

I have no idea why, but Mozilla reverted their distribution too. The source file
is no longer available on any mirrors, binary they distribute is
reverted too.

This is a version of vanilla firefox that supports old plugins, so it
shouldn't be broken.
@grahamc
Copy link
Member

grahamc commented Dec 7, 2017

52.5.2esr was recently tagged, maybe we should upgrade instead

@oxij
Copy link
Member Author

oxij commented Dec 7, 2017 via email

@orivej
Copy link
Contributor

orivej commented Dec 7, 2017

Here they imply that the version published as 52.5.1esr was a release candidate of that version, and the new 52.5.2esr is what was meant to be the release of 52.5.1esr.

Firefox derivation tends to break every second update.

What do you mean? Does it apply to firefox-esr?

@oxij
Copy link
Member Author

oxij commented Dec 7, 2017 via email

@orivej
Copy link
Contributor

orivej commented Dec 7, 2017

My hydra builds Firefox often (when I test mass rebuilding changes), and so far it (including firefox-unwrapped) had never started and then failed to build. I do not know why anyone would want to revert a Firefox update (except the upgrade to 57 because it breaks a lot of plugins, but firefox-esr is the fallback).

@oxij
Copy link
Member Author

oxij commented Dec 8, 2017 via email

@orivej orivej closed this in 86ffdce Dec 8, 2017
@oxij oxij deleted the pkg/firefox-revert branch March 16, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants