Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing 3075: Part 1 #3076

Merged
merged 2 commits into from Dec 15, 2017
Merged

Fixing 3075: Part 1 #3076

merged 2 commits into from Dec 15, 2017

Conversation

aserio
Copy link
Contributor

@aserio aserio commented Dec 14, 2017

This change initializes split_gids_ which is the first step to fixing #3075

@hkaiser hkaiser added this to the 1.1.0 milestone Dec 14, 2017
hkaiser
hkaiser approved these changes Dec 14, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the test are unrelated. But LGTM, thanks!

@msimberg msimberg merged commit ca34c74 into master Dec 15, 2017
@hkaiser hkaiser deleted the fixing_3075 branch January 15, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: serialization type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aserio @hkaiser @msimberg