Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: fixing sha256 #32667

Merged
merged 1 commit into from Dec 14, 2017
Merged

skypeforlinux: fixing sha256 #32667

merged 1 commit into from Dec 14, 2017

Conversation

sjau
Copy link

@sjau sjau commented Dec 14, 2017

Motivation for this change

skypeforlinux Debian Package seems to have changed without altering the version number. So sha256 needs to be updated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

Can you investigate what might have caused this? For all we know it could have been replaced by a malicious version, or is this just the way they do things normally? If so, perhaps users should request better practices on their end.

@sjau
Copy link
Author

sjau commented Dec 14, 2017

No idea how to do that

@orivej
Copy link
Contributor

orivej commented Dec 14, 2017

I have confirmed that the package data did not change. If this happens again we could store and hash the unpacked deb.

@orivej
Copy link
Contributor

orivej commented Dec 14, 2017

The only difference is that the new deb contains a new file _gpgbuilder0: https://gist.github.com/orivej/5598078f1bf643c88d7248d0b3c5227e. It is not part of the package data:

   Mode    User/Group     Size        Date       Filename
--------- -----/-----  -------- ---------------- ----------------
rw-r--r--     0/0             4 2017-11-16 16:16 debian-binary
rw-r--r--     0/0          3966 2017-11-16 16:16 control.tar.gz
rw-r--r--     0/0      72418468 2017-11-16 16:19 data.tar.xz
rw-r--r--     0/0           926 2017-11-22 08:39 _gpgbuilder
rw-r--r--     0/0          1017 2017-12-11 16:25 _gpgbuilder0
--------- -----/-----  -------- ---------------- ----------------

@orivej orivej merged commit 9759b65 into NixOS:master Dec 14, 2017
@joachifm
Copy link
Contributor

Ah, just noticed #32604

@orivej orivej mentioned this pull request Dec 14, 2017
Closed
8 tasks
@orivej orivej added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 14, 2017
@orivej orivej added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sjau @joachifm @orivej @GrahamcOfBorg