pqiv: add dependencies needed to enable all backends #32678
Conversation
|
FWIW, as far as closure sizes and thoughts on backends to use by default: Current / minimal backends: 140MB Seems libarchive/libwebp might as well be included, not sure which of the rest are reasonable defaults. Video seems like an opt-in backend, since it's relatively heavy-weight and pqiv doesn't support sound. |
| ++ stdenv.lib.optional supportPDF poppler | ||
| ++ stdenv.lib.optional supportPS libspectre | ||
| ++ stdenv.lib.optional supportVideo ffmpeg | ||
| ++ stdenv.lib.optional supportWebP libwebp; |
There was a problem hiding this comment.
Do we really need options for all dependencies?
People can do pqiv.override { libarchive = null; } to disable dependencies.
There was a problem hiding this comment.
Also
qiv = callPackage ../applications/graphics/pqiv {
inherit (config.pqiv) enablePDF;
};
is a better approach, since it does not pull options from global namespace.
|
@dtzWill pqiv is a desktop application, so such things as libarchive, libwebp, poppler, imagemagick, ffmpeg are likely present anyway: just add everything by default. Why do you want gtk2? |
|
@orivej okay, sounds good to me! Certainly makes things quite a bit simpler :). I wanted gtk2 for my own purposes -- but if that's the only "option" left... I don't think it's worth bothering with in nixpkgs proper. I'll update the PR shortly :). |
dtzWill
force-pushed
the
feature/pqiv-backends
branch
from
5484bfa
to
e11be36
Compare
dtzWill
changed the title
|
Do you think other users may benefit from the gtk2 version? If so and you want it supported, we should create a |
|
No, it's just because my research project doesn't fully support gtk3 yet O:). If anyone comes around asking for it later we can add it at that point. Thanks though! |
Motivation for this change
Support more formats by default! :)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)