Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.XlsxWriter: init at 1.0.2 #32662

Merged
merged 1 commit into from Dec 16, 2017
Merged

pythonPackages.XlsxWriter: init at 1.0.2 #32662

merged 1 commit into from Dec 16, 2017

Conversation

jluttine
Copy link
Member

Motivation for this change

Add a package which helps Pandas to modify how to save to xlsx files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner December 14, 2017 12:35
@jluttine
Copy link
Member Author

jluttine commented Dec 14, 2017 •
edited

Would it make sense to add an alias xlsxwriter so the package would also be found with lower case letters only?

EDIT: Also, would that make sense in general? We would have both lower-case name and the "official" name exactly as it's written in PyPI.

@FRidh
Copy link
Member

FRidh commented Dec 14, 2017

Would it make sense to add an alias xlsxwriter so the package would also be found with lower case letters only?

For now, no, because more attributes makes it only harder to correctly do an override. Long term, I hope pypi/conveyor#12 is implemented so we can use normalized names for Python packages.

@grahamc
Copy link
Member

grahamc commented Dec 14, 2017

@GrahamcOfBorg eval

@orivej orivej merged commit 97f9bfd into NixOS:master Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jluttine @FRidh @grahamc @orivej @GrahamcOfBorg