Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thefuck: 3.18 -> 3.25 #32672

Merged
merged 1 commit into from Dec 14, 2017
Merged

thefuck: 3.18 -> 3.25 #32672

merged 1 commit into from Dec 14, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Dec 14, 2017

Motivation for this change

Fixes #32670.

Switching to Python 3 because the upstream claims that this is required.

I was not able to make tests pass in the sandbox, even though they do not need anything special. They seem to ignore the environment variables set in the checkPhase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants