Curl: Add brotli support #32165
Merged
Curl: Add brotli support #32165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
curl-7_57_0-brotli
branch
2 times, most recently
from
88636b3
to
af1a1ed
Compare
|
Both dependencies are in staging now. |
orivej
approved these changes
Nov 29, 2017
|
Already rebased on top of staging. Thanks! |
adisbladis
force-pushed
the
curl-7_57_0-brotli
branch
from
af1a1ed
to
8d479c0
Compare
|
Defaults: is there some estimate what (deployed) servers support brotli ATM? |
|
Have you really tested this? For me the log looks OK, but it doesn't retail any reference to brotli... |
|
@vcunat Yes. Tested and it works fine. https://gist.github.com/adisbladis/ccc6cca83fa9ae7835ba6ef36d842d36 https://gist.github.com/adisbladis/ccc6cca83fa9ae7835ba6ef36d842d36#file-curl-brotli-test-L54 and https://gist.github.com/adisbladis/ccc6cca83fa9ae7835ba6ef36d842d36#file-curl-brotli-test-L69 indicates brotli is in use. |
|
|
|
I was looking wrong. It does get into closure. I haven't yet fully got comfortable with nix-1.12 UI, apparently. |
vcunat
approved these changes
Nov 29, 2017
vcunat
added a commit
that referenced
this pull request
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
brotlicompression support to curlDepends on these two PRs:
#32161(merged!)#32123(merged!)When these are merged and the stars are aligned I will rebase this one.(done!)While I would like to enable
brotliby default it's a bit tricky because of circular dependencies.Motivation for this change
Adds brotli support to curl
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)