Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _invariant macro from Float::Printer::* modules #5435

Merged
merged 1 commit into from Jan 5, 2018
Merged

Remove _invariant macro from Float::Printer::* modules #5435

merged 1 commit into from Jan 5, 2018

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Dec 21, 2017

As per #5065 (comment).

@bew
Copy link
Contributor

bew commented Dec 21, 2017

The thing is: were they here for debug only, during dev phase of the float printer? or do they need a replacement for normal use?

@Sija
Copy link
Contributor Author

Sija commented Dec 21, 2017

Asserts are supposed to run only in debug mode, so I'd assume they should be safe to remove.

@Sija
Copy link
Contributor Author

Sija commented Jan 4, 2018

🏓

@RX14
Copy link
Contributor

RX14 commented Jan 5, 2018

These exact asserts actually found #5518, but so would running the spec suite, so I guess they're fine to remove.

@RX14 RX14 added this to the Next milestone Jan 5, 2018
@RX14 RX14 merged commit 315d3c3 into crystal-lang:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sija @bew @RX14 @asterite