python-bitcoinlib: init at 0.9.0 #32948
Conversation
| sha256 = "1s1jm2nid7ab7yiwlp1n2v3was9i4q76xmm07wvzpd2zvn5zb91z"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ openssl ]; |
There was a problem hiding this comment.
I get this error if I don't do this: OSError: libeay32: cannot open shared object file: No such file or directory ¯_(ツ)_/¯
|
How did you test the expression? |
|
There was a problem hiding this comment.
Better use the following to test
nix-shell -p 'python3.withPackages(ps: with ps; [ bitcoinlib ])' -I nixpkgs=. --run 'python3 -c "import bitcoin.rpc"'
Or even better:
$(nix-build -E 'with import ./. {}; python3.withPackages(ps: with ps; [ bitcoinlib ])')/bin/python3 -c "import bitcoin.rpc"
The issue with testing with nix-shell is that it adds build-time dependencies. That's why it could find openssl.
You will need to patch the following line to hardcode a path to that library.
https://github.com/petertodd/python-bitcoinlib/blob/5e150ac4a50791e6293752ceef8647b9bb3273c0/bitcoin/core/key.py#L33
jb55
force-pushed
the
python-bitcoinlib
branch
from
c466b91
to
37bf17a
Compare
|
@FRidh thanks for your help! What do you think about 37bf17a1d3188008dbc943ac450b9b01b8c8b15e ? |
| sha256 = "1s1jm2nid7ab7yiwlp1n2v3was9i4q76xmm07wvzpd2zvn5zb91z"; | ||
| }; | ||
|
|
||
| patchPhase = '' |
There was a problem hiding this comment.
postPatch is preferred so one can still pass along patches.
Signed-off-by: William Casarin <jb55@jb55.com>, @jb55
jb55
force-pushed
the
python-bitcoinlib
branch
from
37bf17a
to
fd45c14
Compare
|
Frederik Rietdijk <notifications@github.com> writes:
`postPatch` is preferred so one can still pass along `patches`.
Done. Thanks!
|
Motivation for this change
This adds the python-bitcoinlib library to nixpkgs
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"