Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: Don't choke if there is no lib output #32549

Merged
merged 1 commit into from Dec 10, 2017
Merged

gcc: Don't choke if there is no lib output #32549

merged 1 commit into from Dec 10, 2017

Conversation

Ericson2314
Copy link
Member

Motivation for this change

#32403 (comment)

Things done

I did not test this yet.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 modified the milestone: 18.03 Dec 10, 2017
@orivej
Copy link
Contributor

orivej commented Dec 10, 2017

This let's gnat start building, but while it builds there is a frequent message:

/nix/store/aij7jgjqkll4jm2ga90iplfp04n5idsl-gentoo-gnatboot-wrapper-4.1/nix-support/utils.sh: line 17: @extraPathTests@: command not found

orivej
orivej approved these changes Dec 10, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, it was printed even before: https://hydra.nixos.org/build/65428666/nixlog/1

@Ericson2314 Ericson2314 merged commit 9f1ab7c into NixOS:staging Dec 10, 2017
@Ericson2314 Ericson2314 deleted the gcc-without-lib-output branch December 10, 2017 23:55
@Ericson2314 Ericson2314 mentioned this pull request Dec 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @orivej @GrahamcOfBorg