@edolstra is there a better way?

is there a better way?

@domenkozar This possibly: NixOS/nixpkgs#32992

@nh2 seems that we are chasing the same problems 😄

I got inspired by your patch, ended up with a different code though. Found that both destroy() and stop() should wait until the operation is done. Interestingly the virualbox backend also has very similar code which waits until the state changes.

Here is my suggestion, it's based on existing code fragments which I found in the end of the file container.py: johbo/nixops@0a5d91a...johbo:work-johbo

Noticed that comments are only possible in real PRs, created #825 for convenience.

@johbo My patch here was intended mainly as a workaround unles/until it gets fixed in nixos-container itself in NixOS/nixpkgs#32992. Then nixops wouldn't need to have any of this logic.

Hello!

Thank you for this PR.

In the past several months, some major changes have taken place in
NixOps:

1. Backends have been removed, preferring a plugin-based architecture.
   Here are some of them:

   • https://github.com/NixOS/nixops-aws
   • https://github.com/NixOS/nixops-hetzner
   • https://github.com/nix-community/nixops-vbox
   • https://github.com/nix-community/nixops-libvirtd
   • https://github.com/nix-community/nixops-datadog

2. NixOps Core has been updated to be Python 3 only, and at the
   same time, MyPy type hints have been added and are now strictly
   required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0
release. There is a tracking issue for that:
#1242 . It is possible that
more core changes will be made to NixOps for this release, with a
focus on simplifying NixOps core and making it easier to use and work
on.

My hope is that by adding types and more thorough automated testing,
it will be easier for contributors to make improvements, and for
contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this
PR cannot merge right now as it is. The backlog of now-unmergable PRs
makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with
master and reopen it. If the or mypy type checking fails, please
correct any issues and then reopen it. I will be looking primarily at
open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be
closing it now.

Graham