Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/doc: document the firewall port ranges options #32540

Merged
merged 1 commit into from Dec 20, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Dec 10, 2017

Motivation for this change

Fix #32055

Things done

interest is
<option>networking.firewall.allowedUDPPorts</option>.

You can open ranges of TCP ports with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to use "You"

Similarly, UDP port ranges can be opened through
<option>networking.firewall.allowedUDPPortRanges</option>.

Also of interest is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this isn't markdown but docbook, so en emtpy line will not produce a new paragraph. You need to close the para tag and open a new one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Dec 20, 2017

Update?

@orivej orivej merged commit b679079 into NixOS:master Dec 20, 2017
@orivej
Copy link
Contributor

orivej commented Dec 20, 2017

Thank you!

@rnhmjoj rnhmjoj deleted the portrange branch January 22, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants