Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Add upcoming deprecations #3099

Merged
merged 1 commit into from Feb 18, 2018
Merged

Add upcoming deprecations #3099

merged 1 commit into from Feb 18, 2018

Conversation

locks
Copy link
Contributor

@locks locks commented Dec 11, 2017

Complements emberjs/ember.js#14590.

@locks locks temporarily deployed to ember-website-pr-3099 December 11, 2017 05:29 Inactive
@locks locks temporarily deployed to ember-website-pr-3099 December 11, 2017 10:59 Inactive
@locks locks temporarily deployed to ember-website-pr-3099 December 12, 2017 12:06 Inactive
@locks locks changed the title WIP | Add 2.8 upcoming deprecations WIP | Add upcoming deprecations Dec 12, 2017
@locks locks temporarily deployed to ember-website-pr-3099 December 12, 2017 17:16 Inactive
@locks locks temporarily deployed to ember-website-pr-3099 December 12, 2017 17:16 Inactive
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove backticks around the id, for consistent formatting

@serenaf
Copy link
Contributor

serenaf commented Jan 30, 2018

Original PR for reference :) emberjs/ember.js#14590

@serenaf
Copy link
Contributor

serenaf commented Jan 30, 2018

@locks According to this https://www.emberjs.com/blog/2018/01/01/ember-2-18-released.html#toc_changes-in-ember-js-2-18 it is since 2.18.0 and until 3.5.0

@locks locks temporarily deployed to ember-website-pr-3099 February 17, 2018 10:14 Inactive
@locks locks temporarily deployed to ember-website-pr-3099 February 17, 2018 10:16 Inactive
@locks locks changed the title WIP | Add upcoming deprecations Add upcoming deprecations Feb 17, 2018
@jenweber
Copy link
Contributor

@locks can you remove backticks around the id? It is a small thing but makes future CSS easier. Also while you're at it, can you promote Ember 2 legacy up a level, so three ### instead of four? It ought to be its own section now that I look at it.

I totally used targetObject in my apps. Oops.

@locks
Copy link
Contributor Author

locks commented Feb 18, 2018

@jenweber done

@jenweber
Copy link
Contributor

I noticed an issue with using backticks in the deprecation title too, but it's a styling problem that affects other listings so I'll open a separate PR/Issue

@jenweber jenweber merged commit 99a3907 into master Feb 18, 2018
@jenweber jenweber deleted the locks-patch-3 branch February 18, 2018 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants