hslib: Function to extract the haskell build inputs of a package. #33012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by extracting out some logic from generic-builder.nix to make it possible to get at the relevant information by overriding mkDerivation for the haskell package.
Ericson2314
approved these changes
Dec 24, 2017
| allPkgconfigDepends = pkgconfigDepends ++ libraryPkgconfigDepends ++ executablePkgconfigDepends ++ | ||
| optionals doCheck testPkgconfigDepends ++ optionals doBenchmark benchmarkPkgconfigDepends; | ||
| inherit (haskellLib.extractBuildInputs ghc (args // { inherit doCheck doBenchmark; })) | ||
| allPkgconfigDepends propagatedBuildInputs otherBuildInputs haskellBuildInputs systemBuildInputs; | ||
|
|
||
| nativeBuildInputs = optional (allPkgconfigDepends != []) pkgconfig ++ |
There was a problem hiding this comment.
Nothing has changed with these, they're not available in pkg.env either...
There was a problem hiding this comment.
There was a problem hiding this comment.
I just mean that the definition of nativeBuildInputs hasn't changed nor has its usage. Nothing in this PR required extracting it out. There's no reason not to do so in the future if there's a need, but there's also no reason to do so now...
|
Reverted in 65138e8. Please give a chance to review before merging changes to the Haskell generic builder. |
|
@peti this was open for 5 days and had a positive review from another significant contributor with no comments from you. Was there any problem with this? |
|
Note that this doesn't change behavior at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works by extracting out some logic from generic-builder.nix to
make it possible to get at the relevant information by overriding
mkDerivation for the haskell package.