Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sshd: Start after network target #33035

Merged
merged 1 commit into from Dec 26, 2017
Merged

sshd: Start after network target #33035

merged 1 commit into from Dec 26, 2017

Conversation

corpix
Copy link
Contributor

@corpix corpix commented Dec 24, 2017

Motivation for this change

I have switched an interface(on which sshd listens) to static ip address and after reboot I got this:

Dec 24 14:28:30 router sshd[826]: error: Bind to port 22 on 10.0.10.1 failed: Cannot assign requested address.
Dec 24 14:28:30 router sshd[826]: fatal: Cannot bind any address.

So I decided to add a network.target as a dependency to sshd service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 25, 2017 •
edited

Just for the record:
The solution proposed here should be ok for static ips configured via networking.interfaces. Otherwise having a .socket unit is a more robust solution using the FreeBind options:

cat /etc/systemd/system/sshd.socket
[Socket]
ListenStream=1984
Accept=yes
FreeBind=true
ReusePort=yes

@Mic92 Mic92 merged commit f1c236a into NixOS:master Dec 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corpix @Mic92 @GrahamcOfBorg