nixos/sway: Extend the descriptions and examples #33015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This'll hopefully make it a bit easier to get started with Sway and make some things about the module more obvious.
primeos
commented
Dec 23, 2017
| @@ -70,4 +80,6 @@ in | |||
| fonts.enableDefaultFonts = mkDefault true; | |||
| programs.dconf.enable = mkDefault true; | |||
| }; | |||
|
|
|||
| meta.maintainers = with lib.maintainers; [ gnidorah primeos ]; | |||
There was a problem hiding this comment.
@gnidorah Quick question: Would you like to maintain this module? And is it ok if I add myself as well?
primeos
commented
Dec 23, 2017
| @@ -56,7 +66,7 @@ in | |||
| environment.systemPackages = [ swayJoined ] ++ cfg.extraPackages; | |||
| security.wrappers.sway = { | |||
| program = "sway-setcap"; | |||
| source = "${sway}/bin/sway"; | |||
| source = "${swayPackage}/bin/sway"; | |||
| capabilities = "cap_sys_ptrace,cap_sys_tty_config=eip"; | |||
| owner = "root"; | |||
| group = "sway"; | |||
There was a problem hiding this comment.
permissions = "u+rx,g+rx";
@Mic92 BTW is there any specific reason to require the sway group here? Normally I would expect user=root, group=root and u=rx,go=x so that every user could execute Sway. Are there any security concerns or did I miss something else?
There was a problem hiding this comment.
This would grant every user to get the ptrace capability and therefor potentially control every other process regardless of uid/gid (through ptracing sway). Therefore it should be handled with care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.