Perhaps we should default to having more/all of the builtin indicators shown? What do you all think? I wonder what's the reasoning of upstream changing the defaults.

Perhaps we should default to having more/all of the builtin indicators shown? What do you all think? I wonder what's the reasoning of upstream changing the defaults.

I am most missing the ~power indicator in the new upstream defaults. I think it could be added to NixOS defaults.

Having found no explanation in upstream for the change, I don't know whether to recommend following the upstream defaults, or diverging in order to maintain a consistent NixOS experience.

This pull request takes the former approach, and I think that's fine. The only thing missing is adding instructions to the release notes nixos/doc/manual/release-notes/rl-1803.xml. The example shown in the NixOS module config ["~host" "~spacer" "~clock" "~spacer" "~session" "~language" "~a11y" "~power" ]; restores the indicators perfectly :)

I tested this change in a VM using the indicators shown above and it worked. To be more specific, I tested the shutdown and restart functionality only, since hibernate is not available in my scenario and I don't know what to expect from suspend.

The only thing missing is adding instructions to the release notes nixos/doc/manual/release-notes/rl-1803.xml

Done. Please, revise it.

There's an extra fullstop in the sentence

If set to null the default clock format is used..

but nevertheless, that's great work, romildo.

There's an extra fullstop in the sentence

Fixed.