New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cacert: add hook that sets SSL_CERT_FILE #33010
Conversation
I am not sure how tests work, but a test like the one I had described in my ticket would be nice to have for something as important as git. It shouldn't checkout all of nixpkgs, but a mini test repository like NixOS/testRepo could be used. Just an idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (as far as r-modules
is concerned).
Still have to run nox-review. |
Don't see any new failures, but there are a lot of changes in staging right now so it might be best to wait a bit. |
@LnL7 FYI apparently |
Oh! I made and tested this before the cross changes where merged, I will take a look. |
Motivation for this change
Fixes #32981
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)