General ruby improvements for vagrant from source #33014
Conversation
|
I am getting a bunch of merge conflicts with nox-review, mind rebasing? Otherwise it looks good. |
| @@ -41,7 +41,6 @@ lib.makeOverridable ( | |||
| , patches ? [] | |||
| , gemPath ? [] | |||
| , dontStrip ? true | |||
| , remotes ? ["https://rubygems.org"] | |||
There was a problem hiding this comment.
couldn't that be kept for backward-compatibility?
There was a problem hiding this comment.
The main reason I moved this under source is because remotes is only useful for some types of sources, e.g. url and gem but not git, and so I wanted to keep this nested under source like the other source-dependent attributes.
Also, I didn't see any places where this is used with a non-default value in Nixpkgs; I fixed the one instance where it was set. I don't think there's a large backwards-compatibility burdnen, as bundix always passes the remotes value under source, so only manual calls to buildRubyGem would be affected.
This allows patching the gemset output by bundix from a default.nix file, making it easier to perform updates since the bundix update no longer has to be manually updated.
Keep the `source` attrset distinct to prevent its entries from merging with the top level attrs. Since each type of source has a different set of entries for `source`, this is the easiest way to keep them together. This will pave the way for a new `url` type of source. This is a mass-rebuild of many ruby packages, notably those using `git` type sources.
aneeshusa
force-pushed
the
general-ruby-improvements-for-vagrant-from-source
branch
from
b3dfa71
to
36f1bcb
Compare
|
@zimbatm rebased on the latest master. |
|
thanks |
Motivation for this change
Extracted general Ruby infrastructure improvements out of #30952.
Review commit-by commit.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)