Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycuda: fix boost_python3 link #33016

Merged
merged 1 commit into from Dec 23, 2017
Merged

pycuda: fix boost_python3 link #33016

merged 1 commit into from Dec 23, 2017

Conversation

dylex
Copy link
Contributor

@dylex dylex commented Dec 23, 2017

Boost python library is now named -lboost_python3 on py3. Without this, link fails on python3. Still fine on python2. Also removed a couple unused inputs.

Motivation for this change

-lboost_python not found on python3 pycuda build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Boost python library now named -lboost_python3 on py3.
Remove a couple unused inputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants