Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost166: init at 1.66.0 #32832

Closed
wants to merge 2 commits into from
Closed

boost166: init at 1.66.0 #32832

wants to merge 2 commits into from

Conversation

tristan0x
Copy link
Contributor

@tristan0x tristan0x commented Dec 19, 2017 •
edited

Motivation for this change

This pull-request provides version 1_66_0 of boost.

Note that the package enables build of Numpy extension, like #32414

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 19, 2017

@GrahamcOfBorg eval

@globin
Copy link
Member

globin commented Dec 19, 2017

Could you change the base to staging and rebase, please?

@tristan0x tristan0x changed the base branch from master to staging December 20, 2017 12:16
@tristan0x
Copy link
Contributor Author

@globin I have changed the base branch and rebased as you requested.

@grahamc
Copy link
Member

grahamc commented Dec 20, 2017

@GrahamcOfBorg eval

@FRidh
Copy link
Member

FRidh commented Dec 20, 2017

I noticed only after merging #32414 but the enableNumpy flag should be added to the function declaration. That way, it would still be possible to create a build with numpy disabled.

@ttuegel ttuegel removed their request for review December 20, 2017 14:35
@tristan0x
Copy link
Contributor Author

Hello @FRidh
Does my last patch fulfill your expectations regarding the capability to disable numpy when building boost 1.65 and higher?

@FRidh
Copy link
Member

FRidh commented Dec 22, 2017

Thank you. I pushed d8a1b34 and 0e37a2c to staging. Note that I split your second commit in two because we prefer to have a commit per expression or change.

@FRidh FRidh closed this Dec 22, 2017
@tristan0x tristan0x deleted the boost/1_66 branch December 22, 2017 08:46
@vcunat
Copy link
Member

vcunat commented Dec 26, 2017

Fortunately the new fortran dependency is build-time only...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tristan0x @grahamc @globin @FRidh @vcunat @GrahamcOfBorg