CODEOWNERS: Add me, @Ericson2314, to a few things please #32827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
changed the title
Ericson2314
commented
Dec 19, 2017
| # Libraries | ||
| /lib @edolstra @nbp | ||
| /lib/systems @edolstra @nbp @ericson2314 |
There was a problem hiding this comment.
I overhauled this thing, a lot of stuff there is mainly needed for cross work / less obvious what it is used for outside of that. I'd also "nominate" @dezgeg to be an owner.
| @@ -10,18 +10,19 @@ | |||
| # This file | |||
| /.github/CODEOWNERS @edolstra | |||
|
|
|||
| # Boostraping and core infra | |||
There was a problem hiding this comment.
I made this category, but then "Nixpkgs Internals" was made, and I don't find this one sufficiently different from that one to warrant keeping it around.
| /pkgs/top-level/stage.nix @nbp @Ericson2314 | ||
| /pkgs/stdenv @edolstra | ||
| /pkgs/build-support/cc-wrapper @edolstra @Ericson2314 | ||
| /pkgs/build-support/bintools-wrapper @edolstra @Ericson2314 |
There was a problem hiding this comment.
The PR of mine making this was just merged, and binutils-wrapper just as important as cc-wrapper (from which it was factored out of) and so everyone owning cc-wrapper should own it too.
|
@GrahamcOfBorg eval |
nbp
approved these changes
Dec 19, 2017
globin
approved these changes
Dec 20, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add myself two a few things. I'll line edit rationals.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)