Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnutar: 1.29 -> 1.30 #32824

Closed
wants to merge 1 commit into from

Conversation

copumpkin
Copy link
Member

Cherry-pick of #32816 to 17.09

Not sure if others even want this in 17.09, but I do, so I'm proposing this and if nobody else wants it, we can just close it 馃槃

@copumpkin copumpkin mentioned this pull request Dec 18, 2017
8 tasks
(cherry picked from commit bba5d62)
@grahamc
Copy link
Member

grahamc commented Dec 19, 2017

@GrahamcOfBorg eval

@edolstra
Copy link
Member

It's not clear to me that 1.30 is purely a bug fix release. I'd rather not have non-bug fix updates on the release branch, especially when they're stdenv changes.

@copumpkin
Copy link
Member Author

@edolstra understandable. My sense is that it's mostly bugfix, with the only new feature being a --warnings command-line option. My motivation for putting it here is that if we're going to put out a Nix 1.12 pointing at a 17.09 stable on Darwin, I'd like it to include a gnutar that can produce cross-platform deterministic tarballs, and this is the first version to include that fix. It also natively includes a CVE patch that we were applying manually and a couple of other fixes, but indeed it does seem to have one new feature. If you still think it's a bad idea, I won't put up a fight.

@FRidh
Copy link
Member

FRidh commented Feb 11, 2018

Closing because of inactivity.

@FRidh FRidh closed this Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants